Skip to content

Bump Bazel version to 8.3.1, migrate to bzlmod and bump LLVM to latest#49

Merged
j2kun merged 19 commits intoj2kun:mainfrom
SihaoLiu:main
Jul 18, 2025
Merged

Bump Bazel version to 8.3.1, migrate to bzlmod and bump LLVM to latest#49
j2kun merged 19 commits intoj2kun:mainfrom
SihaoLiu:main

Conversation

@SihaoLiu
Copy link
Contributor

@SihaoLiu SihaoLiu commented Jul 15, 2025 •
edited
Loading

Hi @j2kun

Thank you so much for your very helpful tutorial on MLIR. I really enjoy reading your words and really learn from you.

I found the bazel version is a little bit old, so I upgrade it to bazel 8.3.1 and migrate most of dependency to bzlmod.

I also bump LLVM version to latest as today (July 17, 2025)

Thank you again for providing such valuable tutorial

j2kun
j2kun requested changes Jul 15, 2025
View reviewed changes
Copy link
Owner

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful! I did not previously know how to put the llvm configuration part in MODULE.bazel, despite having done this migration on my main MLIR project (google/heir) already.

Can you also remove the bazel/import_llvm.bzl and related files that are no longer used?

@j2kun
Copy link
Owner

j2kun commented Jul 16, 2025

If you rebase over main you should get the fixes to the github action

@SihaoLiu
Copy link
Contributor Author

SihaoLiu commented Jul 16, 2025

If you rebase over main you should get the fixes to the github action

Thanks will do. I also bump the LLVM version to latest but haven't really finished. Will absorb all your comments later

@SihaoLiu
Copy link
Contributor Author

SihaoLiu commented Jul 17, 2025

If you rebase over main you should get the fixes to the github action

Do you mind taking another look? Building seems work on my local machine. I also bump the LLVM to the latest version with some fixes in original code. hope I adopted all your suggestions.

@SihaoLiu SihaoLiu requested a review from j2kun July 17, 2025 18:06
@SihaoLiu SihaoLiu changed the title Bump Bazel version to 8.3.1 and migrate to bzlmod Bump Bazel version to 8.3.1, migrate to bzlmod and bump LLVM to latest Jul 17, 2025
SihaoLiu added 2 commits July 17, 2025 13:36
@SihaoLiu
update LLVM submodule version used by cmake flow and update CI to use…
7b836d4 
… latest file to get llvm commit hash
@SihaoLiu
Merge pull request #1 from SihaoLiu/update-cmake-llvm-github-ci
0ec6f2c 
update LLVM submodule version used by cmake flow and update CI
@SihaoLiu
Copy link
Contributor Author

SihaoLiu commented Jul 17, 2025 •
edited
Loading

@j2kun I believe this CI failure (56697c4) is caused by CI's yml file still try to use bazel/import_llvm.bzl and the submodule commit hash is not updated. I already fixed it. Can you kick off CI again?

j2kun
j2kun approved these changes Jul 18, 2025
View reviewed changes
Copy link
Owner

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for CI to pass

@SihaoLiu
Copy link
Contributor Author

SihaoLiu commented Jul 18, 2025

LGTM, just waiting for CI to pass

Thanks! I think CI passed and really happy to contribute. 😃

@j2kun j2kun merged commit bf40cc2 into j2kun:main Jul 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j2kun j2kun j2kun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SihaoLiu @j2kun